base: Remove most uses of MessageLoopProxy

base/memory/weak_ptr_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/weak_ptr.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/debug/leak_annotations.h"
+#include "base/location.h"
 #include "base/memory/scoped_ptr.h"
-#include "base/message_loop/message_loop.h"
+#include "base/single_thread_task_runner.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/threading/thread.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace base {
 namespace {
 
 template <class T>
 class OffThreadObjectCreator {
  public:
   static T* NewObject() {
     T* result;
     {
       Thread creator_thread("creator_thread");
       creator_thread.Start();
-      creator_thread.message_loop()->PostTask(
-          FROM_HERE,
-          base::Bind(OffThreadObjectCreator::CreateObject, &result));
+      creator_thread.message_loop()->task_runner()->PostTask(

[danakj, 2015/04/21 20:16:30]

why message_loop()->task_runner() instead of just task_runner()?

[Sami, 2015/04/23 17:48:24]

Hmm, I thought I applied that shortcut everywhere but looks like I missed some
places (here and elsewhere). Thanks for pointing this out!

+          FROM_HERE, base::Bind(OffThreadObjectCreator::CreateObject, &result));
     }
     DCHECK(result);  // We synchronized on thread destruction above.
     return result;
   }
  private:
   static void CreateObject(T** result) {
     *result = new T;
   }
 };
 
@@ skipping 18 matching lines @@
 // Helper class to create and destroy weak pointer copies
 // and delete objects on a background thread.
 class BackgroundThread : public Thread {
  public:
   BackgroundThread() : Thread("owner_thread") {}
 
   ~BackgroundThread() override { Stop(); }
 
   void CreateArrowFromTarget(Arrow** arrow, Target* target) {
     WaitableEvent completion(true, false);
-    message_loop()->PostTask(
-        FROM_HERE,
-        base::Bind(&BackgroundThread::DoCreateArrowFromTarget,
-                   arrow, target, &completion));
+    message_loop()->task_runner()->PostTask(

[danakj, 2015/04/21 20:16:30]

dittos

[Sami, 2015/04/23 17:48:24]

Done.

+        FROM_HERE, base::Bind(&BackgroundThread::DoCreateArrowFromTarget, arrow,
+                              target, &completion));
     completion.Wait();
   }
 
   void CreateArrowFromArrow(Arrow** arrow, const Arrow* other) {
     WaitableEvent completion(true, false);
-    message_loop()->PostTask(
-        FROM_HERE,
-        base::Bind(&BackgroundThread::DoCreateArrowFromArrow,
-                   arrow, other, &completion));
+    message_loop()->task_runner()->PostTask(
+        FROM_HERE, base::Bind(&BackgroundThread::DoCreateArrowFromArrow, arrow,
+                              other, &completion));
     completion.Wait();
   }
 
   void DeleteTarget(Target* object) {
     WaitableEvent completion(true, false);
-    message_loop()->PostTask(
+    message_loop()->task_runner()->PostTask(
         FROM_HERE,
         base::Bind(&BackgroundThread::DoDeleteTarget, object, &completion));
     completion.Wait();
   }
 
   void CopyAndAssignArrow(Arrow* object) {
     WaitableEvent completion(true, false);
-    message_loop()->PostTask(
-        FROM_HERE,
-        base::Bind(&BackgroundThread::DoCopyAndAssignArrow,
-                   object, &completion));
+    message_loop()->task_runner()->PostTask(
+        FROM_HERE, base::Bind(&BackgroundThread::DoCopyAndAssignArrow, object,
+                              &completion));
     completion.Wait();
   }
 
   void CopyAndAssignArrowBase(Arrow* object) {
     WaitableEvent completion(true, false);
-    message_loop()->PostTask(
-        FROM_HERE,
-        base::Bind(&BackgroundThread::DoCopyAndAssignArrowBase,
-                   object, &completion));
+    message_loop()->task_runner()->PostTask(
+        FROM_HERE, base::Bind(&BackgroundThread::DoCopyAndAssignArrowBase,
+                              object, &completion));
     completion.Wait();
   }
 
   void DeleteArrow(Arrow* object) {
     WaitableEvent completion(true, false);
-    message_loop()->PostTask(
+    message_loop()->task_runner()->PostTask(
         FROM_HERE,
         base::Bind(&BackgroundThread::DoDeleteArrow, object, &completion));
     completion.Wait();
   }
 
   Target* DeRef(const Arrow* arrow) {
     WaitableEvent completion(true, false);
     Target* result = NULL;
-    message_loop()->PostTask(
+    message_loop()->task_runner()->PostTask(
         FROM_HERE,
         base::Bind(&BackgroundThread::DoDeRef, arrow, &result, &completion));
     completion.Wait();
     return result;
   }
 
  protected:
   static void DoCreateArrowFromArrow(Arrow** arrow,
                                      const Arrow* other,
                                      WaitableEvent* completion) {
@@ skipping 474 matching lines @@
   background.Start();
   background.DeleteTarget(target.release());
 
   // Main thread attempts to dereference the target, violating thread binding.
   ASSERT_DEATH(arrow.target.get(), "");
 }
 
 #endif
 
 }  // namespace base