content/renderer/java/gin_java_bridge_value_converter.cc - Issue 1100763002: Inject CanAddURLToHistory into TopSitesImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/java/gin_java_bridge_value_converter.cc

Issue 1100763002: Inject CanAddURLToHistory into TopSitesImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prefs

Patch Set: Fix error introduced during rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/java/gin_java_bridge_value_converter.cc

diff --git a/content/renderer/java/gin_java_bridge_value_converter.cc b/content/renderer/java/gin_java_bridge_value_converter.cc

index 64860822e0725b82d4f367f4b312a17be6dcfd90..c8bd877ad5c2ca41778afc0a9643cd36f3d35e73 100644

--- a/content/renderer/java/gin_java_bridge_value_converter.cc

+++ b/content/renderer/java/gin_java_bridge_value_converter.cc

@@ -73,7 +73,7 @@ class TypedArraySerializerImpl : public TypedArraySerializer {

new TypedArraySerializerImpl<ElementType, ListType>(typed_array));

}

- virtual void serializeTo(char* data,

+ void serializeTo(char* data,

size_t data_length,

base::ListValue* out) override {

DCHECK_EQ(data_length, typed_array_->Length() * sizeof(ElementType));