Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: remoting/webapp/build_template.gni

Issue 1100763002: Inject CanAddURLToHistory into TopSitesImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prefs
Patch Set: Fix error introduced during rebase Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/build-webapp.py ('k') | remoting/webapp/crd/js/client_session.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/build_template.gni
diff --git a/remoting/webapp/build_template.gni b/remoting/webapp/build_template.gni
index d1e2265a206ca6c62f8b0252eecf9f66a1b60528..70ff555feab28283ee03b1110306ec0a6ba957f9 100644
--- a/remoting/webapp/build_template.gni
+++ b/remoting/webapp/build_template.gni
@@ -72,6 +72,16 @@ template("remoting_webapp") {
"$target_gen_dir/wcs_sandbox.html",
]
+ # Create a file that contains a list of all the resource files needed
+ # to build the webapp. This is needed to avoid problems on platforms that
+ # limit the size of a command line.
+ file_list = "$target_gen_dir/${target_name}_file_list.txt"
+ files = []
+ files += rebase_path(generated_html_files, root_build_dir)
+ files += rebase_path(remoting_webapp_crd_files, root_build_dir)
+ files += rebase_path(extra_files, root_build_dir)
+ write_file(file_list, files)
+
args = [
buildtype,
version_full,
@@ -80,9 +90,10 @@ template("remoting_webapp") {
rebase_path("crd/manifest.json.jinja2", root_build_dir),
webapp_type,
]
- args += rebase_path(generated_html_files, root_build_dir)
- args += rebase_path(remoting_webapp_crd_files, root_build_dir)
- args += rebase_path(extra_files, root_build_dir)
+ args += [
+ "--files_listfile",
+ rebase_path(file_list, root_build_dir),
+ ]
args += [
"--locales_listfile",
listfile_rel,
« no previous file with comments | « remoting/webapp/build-webapp.py ('k') | remoting/webapp/crd/js/client_session.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698