chrome/browser/download/download_browsertest.cc - Issue 1100763002: Inject CanAddURLToHistory into TopSitesImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_browsertest.cc

Issue 1100763002: Inject CanAddURLToHistory into TopSitesImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prefs

Patch Set: Fix error introduced during rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_browsertest.cc

diff --git a/chrome/browser/download/download_browsertest.cc b/chrome/browser/download/download_browsertest.cc

index cc4bb5984dea7468d05cb1157d9826e641ece2cf..39caea3ca4b585e2fd71affb68ebae2e15149909 100644

--- a/chrome/browser/download/download_browsertest.cc

+++ b/chrome/browser/download/download_browsertest.cc

@@ -3427,9 +3427,9 @@ class DisableSafeBrowsingOnInProgressDownload

final_state_seen_(false) {

Init();

}

- virtual ~DisableSafeBrowsingOnInProgressDownload() {}

+ ~DisableSafeBrowsingOnInProgressDownload() override {}

- virtual bool IsDownloadInFinalState(DownloadItem* download) override {

+ bool IsDownloadInFinalState(DownloadItem* download) override {

if (download->GetState() != DownloadItem::IN_PROGRESS ||

download->GetTargetFilePath().empty())

return false;