Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4456)

Unified Diff: chrome/browser/ui/webui/help/version_updater_win.cc

Issue 1100763002: Inject CanAddURLToHistory into TopSitesImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prefs
Patch Set: Fix error introduced during rebase Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/help/version_updater_win.cc
diff --git a/chrome/browser/ui/webui/help/version_updater_win.cc b/chrome/browser/ui/webui/help/version_updater_win.cc
index 9825fe02ff594e9ff129e41332640258b8937fea..4311801f55c31473ff5b3f1a66e2446e36601593 100644
--- a/chrome/browser/ui/webui/help/version_updater_win.cc
+++ b/chrome/browser/ui/webui/help/version_updater_win.cc
@@ -36,11 +36,11 @@ class VersionUpdaterWin : public VersionUpdater {
// Clients must use VersionUpdater::Create().
VersionUpdaterWin();
- virtual ~VersionUpdaterWin();
+ ~VersionUpdaterWin() override;
// VersionUpdater implementation.
- virtual void CheckForUpdate(const StatusCallback& callback) override;
- virtual void RelaunchBrowser() const override;
+ void CheckForUpdate(const StatusCallback& callback) override;
+ void RelaunchBrowser() const override;
// chrome::UpdateCheckCallback.
void OnUpdateCheckResults(GoogleUpdateUpgradeResult result,
@@ -62,12 +62,12 @@ class VersionUpdaterWin : public VersionUpdater {
void BeginUpdateCheckOnFileThread(bool install_if_newer);
- // Used for callbacks.
- base::WeakPtrFactory<VersionUpdaterWin> weak_factory_;
-
// Callback used to communicate update status to the client.
StatusCallback callback_;
+ // Used for callbacks.
+ base::WeakPtrFactory<VersionUpdaterWin> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(VersionUpdaterWin);
};

Powered by Google App Engine
This is Rietveld 408576698