third_party/mojo/src/mojo/public/tools/dart_analyze.py - Issue 1100763002: Inject CanAddURLToHistory into TopSitesImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/mojo/src/mojo/public/tools/dart_analyze.py

Issue 1100763002: Inject CanAddURLToHistory into TopSitesImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prefs

Patch Set: Fix error introduced during rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/mojo/src/mojo/public/tools/dart_analyze.py

diff --git a/third_party/mojo/src/mojo/public/tools/dart_analyze.py b/third_party/mojo/src/mojo/public/tools/dart_analyze.py

index cb80804bad44416dafe85bebb4e5d2ed40e84be4..b90cbef558dd3652c409b7767ca2fb32598cf85f 100755

--- a/third_party/mojo/src/mojo/public/tools/dart_analyze.py

+++ b/third_party/mojo/src/mojo/public/tools/dart_analyze.py

@@ -29,6 +29,8 @@ _IGNORED_PATTERNS = [

# TODO: It seems like this should be re-enabled evenutally.

re.compile(r'.*is a part and can not|^Only libraries can be analyzed'),

+ # TODO: Remove this once dev SDK includes Uri.directory constructor.

+ re.compile(r'.*The class \'Uri\' does not have a constructor \'directory\''),

]

def _success(stamp_file):