content/browser/browser_url_handler_impl.cc - Issue 1100763002: Inject CanAddURLToHistory into TopSitesImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_url_handler_impl.cc

Issue 1100763002: Inject CanAddURLToHistory into TopSitesImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prefs

Patch Set: Fix error introduced during rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/browser_url_handler_impl.cc

diff --git a/content/browser/browser_url_handler_impl.cc b/content/browser/browser_url_handler_impl.cc

index 438feb3ac4ec7df6b51cebf8b76970cdcefce9e6..63ddf4924b8a3457dfb4e361519650e2c2a37d98 100644

--- a/content/browser/browser_url_handler_impl.cc

+++ b/content/browser/browser_url_handler_impl.cc

@@ -89,7 +89,7 @@ BrowserURLHandlerImpl* BrowserURLHandlerImpl::GetInstance() {

}

BrowserURLHandlerImpl::BrowserURLHandlerImpl() :

- fixup_handler_(null_handler()) {

+ fixup_handler_(nullptr) {

AddHandlerPair(&DebugURLHandler, BrowserURLHandlerImpl::null_handler());

GetContentClient()->browser()->BrowserURLHandlerCreated(this);

@@ -102,7 +102,7 @@ BrowserURLHandlerImpl::~BrowserURLHandlerImpl() {

}

void BrowserURLHandlerImpl::SetFixupHandler(URLHandler handler) {

- DCHECK_EQ(null_handler(), fixup_handler_);

+ DCHECK(fixup_handler_ == nullptr);

fixup_handler_ = handler;

}