Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 1100763002: Inject CanAddURLToHistory into TopSitesImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prefs
Patch Set: Fix error introduced during rebase Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.h
diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h
index fe463d3614c79b8d5b200af0b65cc69702011ff7..336be3eca579f043ef5a512327f54276477fbd1e 100644
--- a/content/browser/service_worker/service_worker_version.h
+++ b/content/browser/service_worker/service_worker_version.h
@@ -286,6 +286,9 @@ class CONTENT_EXPORT ServiceWorkerVersion
void ReportError(ServiceWorkerStatusCode status,
const std::string& status_message);
+ // Sets the status code to pass to StartWorker callbacks if start fails.
+ void SetStartWorkerStatusCode(ServiceWorkerStatusCode status);
+
// Sets this version's status to REDUNDANT and deletes its resources.
// The version must not have controllees.
void Doom();
@@ -543,6 +546,12 @@ class CONTENT_EXPORT ServiceWorkerVersion
std::vector<int> pending_skip_waiting_requests_;
scoped_ptr<net::HttpResponseInfo> main_script_http_info_;
+ // The status when StartWorker was invoked. Used for UMA.
+ Status prestart_status_ = NEW;
+ // If not OK, the reason that StartWorker failed. Used for
+ // running |start_callbacks_|.
+ ServiceWorkerStatusCode start_worker_status_ = SERVICE_WORKER_OK;
+
base::WeakPtrFactory<ServiceWorkerVersion> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(ServiceWorkerVersion);

Powered by Google App Engine
This is Rietveld 408576698