extensions/common/api/web_view_internal.json - Issue 1100763002: Inject CanAddURLToHistory into TopSitesImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/api/web_view_internal.json

Issue 1100763002: Inject CanAddURLToHistory into TopSitesImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prefs

Patch Set: Fix error introduced during rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/api/web_view_internal.json

diff --git a/extensions/common/api/web_view_internal.json b/extensions/common/api/web_view_internal.json

index a2d679b857de05d69cf9601c13e5b6db96636799..1ecfba4112179769f1ad5f1026d9cebc84e7e8c5 100644

--- a/extensions/common/api/web_view_internal.json

+++ b/extensions/common/api/web_view_internal.json

@@ -95,11 +95,6 @@

"enum": ["allow", "deny", "default"]

{

- "id": "RunLocation",

- "type": "string",

- "enum": ["document_start", "document_end", "document_idle"]

- },

- {

"id": "ContentScriptDetails",

"type": "object",

"description": "Details of the content script to inject.",

@@ -137,8 +132,7 @@

"description": "The list of JavaScript files to be injected into matching pages. These are injected in the order they appear in this array."

"run_at": {

- // TODO(hanxi): change the reference to extensionTypes.RunAt after http://crbug.com/477457 is fixed.

- "$ref": "RunLocation",

+ "$ref": "extensionTypes.RunAt",

"optional": true,

"description": "The soonest that the JavaScript or CSS will be injected into the tab. Defaults to \"document_idle\"."