Inject CanAddURLToHistory into TopSitesImpl

components/history/content/browser/content_history_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // History unit tests come in two flavors:
 //
 // 1. The more complicated style is that the unit test creates a full history
 //    service. This spawns a background thread for the history backend, and
 //    all communication is asynchronous. This is useful for testing more
 //    complicated things or end-to-end behavior.
@@ skipping 24 matching lines @@
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/task/cancelable_task_tracker.h"
 #include "base/threading/platform_thread.h"
 #include "base/time/time.h"
-#include "chrome/common/chrome_constants.h"
-#include "chrome/common/chrome_paths.h"
-#include "components/history/content/browser/download_constants_utils.h"
-#include "components/history/content/browser/history_database_helper.h"
 #include "components/history/core/browser/download_constants.h"
 #include "components/history/core/browser/download_row.h"
 #include "components/history/core/browser/history_backend.h"
 #include "components/history/core/browser/history_constants.h"
 #include "components/history/core/browser/history_database.h"
 #include "components/history/core/browser/history_database_params.h"
 #include "components/history/core/browser/history_db_task.h"
 #include "components/history/core/browser/history_service.h"
 #include "components/history/core/browser/in_memory_database.h"
 #include "components/history/core/browser/in_memory_history_backend.h"
 #include "components/history/core/browser/page_usage_data.h"
 #include "components/history/core/common/thumbnail_score.h"
+#include "components/history/core/test/database_test_utils.h"
 #include "components/history/core/test/history_unittest_base.h"
 #include "components/history/core/test/test_history_database.h"
 #include "components/history/core/test/thumbnail-inl.h"
-#include "content/public/browser/download_item.h"
-#include "content/public/browser/notification_details.h"
-#include "content/public/browser/notification_source.h"
 #include "sql/connection.h"
 #include "sql/statement.h"
 #include "sync/api/attachments/attachment_id.h"
 #include "sync/api/fake_sync_change_processor.h"
 #include "sync/api/sync_change.h"
 #include "sync/api/sync_change_processor.h"
 #include "sync/api/sync_change_processor_wrapper_for_test.h"
 #include "sync/api/sync_error.h"
 #include "sync/api/sync_error_factory.h"
 #include "sync/api/sync_merge_result.h"
 #include "sync/internal_api/public/attachments/attachment_service_proxy_for_test.h"
 #include "sync/protocol/history_delete_directive_specifics.pb.h"
 #include "sync/protocol/sync.pb.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/codec/jpeg_codec.h"
 
 using base::Time;
 using base::TimeDelta;
-using content::DownloadItem;
 
 namespace history {
 class HistoryBackendDBTest;
 
 // Delegate class for when we create a backend without a HistoryService.
 //
 // This must be outside the anonymous namespace for the friend statement in
 // HistoryBackendDBTest to work.
 class BackendDelegate : public HistoryBackend::Delegate {
  public:
@@ skipping 33 matching lines @@
   ~HistoryBackendDBTest() override {}
 
  protected:
   friend class BackendDelegate;
 
   // Creates the HistoryBackend and HistoryDatabase on the current thread,
   // assigning the values to backend_ and db_.
   void CreateBackendAndDatabase() {
     backend_ = new HistoryBackend(new BackendDelegate(this), nullptr);
     backend_->Init(std::string(), false,
-                   HistoryDatabaseParamsForPath(history_dir_));
+                   TestHistoryDatabaseParamsForPath(history_dir_));
     db_ = backend_->db_.get();
     DCHECK(in_mem_backend_) << "Mem backend should have been set by "
         "HistoryBackend::Init";
   }
 
   void CreateDBVersion(int version) {
     base::FilePath data_path;
-    ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &data_path));
-    data_path = data_path.AppendASCII("History");
+    ASSERT_TRUE(GetTestDataHistoryDir(&data_path));
     data_path =
           data_path.AppendASCII(base::StringPrintf("history.%d.sql", version));
     ASSERT_NO_FATAL_FAILURE(
         ExecuteSQLScript(data_path, history_dir_.Append(kHistoryFilename)));
   }
 
   void CreateArchivedDB() {
     base::FilePath data_path;
-    ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &data_path));
-    data_path = data_path.AppendASCII("History");
+    ASSERT_TRUE(GetTestDataHistoryDir(&data_path));
     data_path = data_path.AppendASCII("archived_history.4.sql");
     ASSERT_NO_FATAL_FAILURE(ExecuteSQLScript(
         data_path, history_dir_.Append(kArchivedHistoryFilename)));
   }
 
   // testing::Test
   void SetUp() override {
     ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
     history_dir_ = temp_dir_.path().AppendASCII("HistoryBackendDBTest");
     ASSERT_TRUE(base::CreateDirectory(history_dir_));
@@ skipping 27 matching lines @@
                          "application/vnd.oasis.opendocument.text",
                          "application/octet-stream",
                          time,
                          time,
                          std::string(),
                          std::string(),
                          0,
                          512,
                          state,
                          DownloadDangerType::NOT_DANGEROUS,
-                         ToHistoryDownloadInterruptReason(
-                            content::DOWNLOAD_INTERRUPT_REASON_NONE),
+                         kTestDownloadInterruptReasonNone,
                          id,
                          false,
                          "by_ext_id",
                          "by_ext_name");
     return db_->CreateDownload(download);
   }
 
   base::ScopedTempDir temp_dir_;
 
   base::MessageLoopForUI message_loop_;
@@ skipping 37 matching lines @@
   EXPECT_EQ(1UL, downloads[0].url_chain.size());
   EXPECT_EQ(GURL("foo-url"), downloads[0].url_chain[0]);
   EXPECT_EQ(std::string("http://referrer.com/"),
             std::string(downloads[0].referrer_url.spec()));
   EXPECT_EQ(now, downloads[0].start_time);
   EXPECT_EQ(now, downloads[0].end_time);
   EXPECT_EQ(0, downloads[0].received_bytes);
   EXPECT_EQ(512, downloads[0].total_bytes);
   EXPECT_EQ(DownloadState::COMPLETE, downloads[0].state);
   EXPECT_EQ(DownloadDangerType::NOT_DANGEROUS, downloads[0].danger_type);
-  EXPECT_EQ(content::DOWNLOAD_INTERRUPT_REASON_NONE,
-            downloads[0].interrupt_reason);
+  EXPECT_EQ(kTestDownloadInterruptReasonNone, downloads[0].interrupt_reason);
   EXPECT_FALSE(downloads[0].opened);
   EXPECT_EQ("by_ext_id", downloads[0].by_ext_id);
   EXPECT_EQ("by_ext_name", downloads[0].by_ext_name);
   EXPECT_EQ("application/vnd.oasis.opendocument.text", downloads[0].mime_type);
   EXPECT_EQ("application/octet-stream", downloads[0].original_mime_type);
 
   db_->QueryDownloads(&downloads);
   EXPECT_EQ(1U, downloads.size());
   db_->RemoveDownload(id);
   db_->QueryDownloads(&downloads);
@@ skipping 130 matching lines @@
     {
       base::Time nowish(base::Time::FromTimeT(now.ToTimeT()));
 
       // Confirm downloads table is valid.
       sql::Statement statement(db.GetUniqueStatement(
           "SELECT id, interrupt_reason, current_path, target_path, "
           "       danger_type, start_time, end_time "
           "FROM downloads ORDER BY id"));
       EXPECT_TRUE(statement.Step());
       EXPECT_EQ(1, statement.ColumnInt64(0));
-      EXPECT_EQ(content::DOWNLOAD_INTERRUPT_REASON_NONE,
+      EXPECT_EQ(DownloadInterruptReasonToInt(kTestDownloadInterruptReasonNone),
                 statement.ColumnInt(1));
       EXPECT_EQ("", statement.ColumnString(2));
       EXPECT_EQ("", statement.ColumnString(3));
       // Implicit dependence on value of kDangerTypeNotDangerous from
       // download_database.cc.
       EXPECT_EQ(0, statement.ColumnInt(4));
       EXPECT_EQ(nowish.ToInternalValue(), statement.ColumnInt64(5));
       EXPECT_EQ(nowish.ToInternalValue(), statement.ColumnInt64(6));
 
       EXPECT_TRUE(statement.Step());
       EXPECT_EQ(2, statement.ColumnInt64(0));
-      EXPECT_EQ(content::DOWNLOAD_INTERRUPT_REASON_NONE,
+      EXPECT_EQ(DownloadInterruptReasonToInt(kTestDownloadInterruptReasonNone),
                 statement.ColumnInt(1));
       EXPECT_EQ("/path/to/some/file", statement.ColumnString(2));
       EXPECT_EQ("/path/to/some/file", statement.ColumnString(3));
       EXPECT_EQ(0, statement.ColumnInt(4));
       EXPECT_EQ(nowish.ToInternalValue(), statement.ColumnInt64(5));
       EXPECT_EQ(nowish.ToInternalValue(), statement.ColumnInt64(6));
 
       EXPECT_FALSE(statement.Step());
     }
     {
@@ skipping 333 matching lines @@
                        "application/octet-stream",
                        "application/octet-stream",
                        now,
                        now,
                        std::string(),
                        std::string(),
                        0,
                        512,
                        DownloadState::COMPLETE,
                        DownloadDangerType::NOT_DANGEROUS,
-                       ToHistoryDownloadInterruptReason(
-                          content::DOWNLOAD_INTERRUPT_REASON_NONE),
+                       kTestDownloadInterruptReasonNone,
                        1,
                        0,
                        "by_ext_id",
                        "by_ext_name");
 
   // Creating records without any urls should fail.
   EXPECT_FALSE(db_->CreateDownload(download));
 
   download.url_chain.push_back(GURL("foo-url"));
   EXPECT_TRUE(db_->CreateDownload(download));
@@ skipping 43 matching lines @@
     sql::Statement statement(db.GetUniqueStatement(
         "Select Count(*) from downloads"));
     EXPECT_TRUE(statement.Step());
     EXPECT_EQ(1, statement.ColumnInt(0));
 
     sql::Statement statement1(db.GetUniqueStatement(
         "Select state, interrupt_reason from downloads"));
     EXPECT_TRUE(statement1.Step());
     EXPECT_EQ(DownloadStateToInt(DownloadState::IN_PROGRESS),
               statement1.ColumnInt(0));
-    EXPECT_EQ(content::DOWNLOAD_INTERRUPT_REASON_NONE, statement1.ColumnInt(1));
+    EXPECT_EQ(DownloadInterruptReasonToInt(kTestDownloadInterruptReasonNone),
+              statement1.ColumnInt(1));
     EXPECT_FALSE(statement1.Step());
   }
 
   // Read in the DB through query downloads, then test that the
   // right transformation was returned.
   CreateBackendAndDatabase();
   std::vector<DownloadRow> results;
   db_->QueryDownloads(&results);
   ASSERT_EQ(1u, results.size());
   EXPECT_EQ(DownloadState::INTERRUPTED, results[0].state);
-  EXPECT_EQ(content::DOWNLOAD_INTERRUPT_REASON_CRASH,
-            results[0].interrupt_reason);
+  EXPECT_EQ(kTestDownloadInterruptReasonCrash, results[0].interrupt_reason);
 
   // Allow the update to propagate, shut down the DB, and confirm that
   // the query updated the on disk database as well.
   base::MessageLoop::current()->RunUntilIdle();
   DeleteBackend();
   {
     sql::Connection db;
     ASSERT_TRUE(db.Open(history_dir_.Append(kHistoryFilename)));
     sql::Statement statement(db.GetUniqueStatement(
         "Select Count(*) from downloads"));
     EXPECT_TRUE(statement.Step());
     EXPECT_EQ(1, statement.ColumnInt(0));
 
     sql::Statement statement1(db.GetUniqueStatement(
         "Select state, interrupt_reason from downloads"));
     EXPECT_TRUE(statement1.Step());
     EXPECT_EQ(DownloadStateToInt(DownloadState::INTERRUPTED),
               statement1.ColumnInt(0));
-    EXPECT_EQ(content::DOWNLOAD_INTERRUPT_REASON_CRASH,
+    EXPECT_EQ(DownloadInterruptReasonToInt(kTestDownloadInterruptReasonCrash),
               statement1.ColumnInt(1));
     EXPECT_FALSE(statement1.Step());
   }
 }
 
 struct InterruptReasonAssociation {
   std::string name;
   int value;
 };
 
@@ skipping 98 matching lines @@
 
  protected:
   friend class BackendDelegate;
 
   // testing::Test
   void SetUp() override {
     ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
     history_dir_ = temp_dir_.path().AppendASCII("HistoryTest");
     ASSERT_TRUE(base::CreateDirectory(history_dir_));
     history_service_.reset(new history::HistoryService);
-    if (!history_service_->Init(std::string(),
-                                HistoryDatabaseParamsForPath(history_dir_))) {
+    if (!history_service_->Init(
+            std::string(), TestHistoryDatabaseParamsForPath(history_dir_))) {
       history_service_.reset();
       ADD_FAILURE();
     }
   }
 
   void TearDown() override {
     if (history_service_)
       CleanupHistoryService();
 
     // Make sure we don't have any event pending that could disrupt the next
@@ skipping 846 matching lines @@
   std::vector<PageUsageData*> results;
   db_->QuerySegmentUsage(segment_time, 10, &results);
   ASSERT_EQ(1u, results.size());
   EXPECT_EQ(url, results[0]->GetURL());
   EXPECT_EQ(segment_id, results[0]->GetID());
   EXPECT_EQ(title, results[0]->GetTitle());
   STLDeleteElements(&results);
 }
 
 }  // namespace history