Chromium Code Reviews| Index: gin/public/isolate_holder.h |
| diff --git a/gin/public/isolate_holder.h b/gin/public/isolate_holder.h |
| index ba75cd8f11654f653806776be1c750acd78e75a5..f5b639237a897f5859c48bb5677fd91cbf5f2afd 100644 |
| --- a/gin/public/isolate_holder.h |
| +++ b/gin/public/isolate_holder.h |
| @@ -27,7 +27,14 @@ class GIN_EXPORT IsolateHolder { |
| kStrictMode |
| }; |
| + // Stores whether the client uses v8::Locker to access the isolate. |
| + enum AccessMode { |
| + kSingleThread, |
| + kUseLocker |
| + }; |
| + |
| IsolateHolder(); |
| + IsolateHolder(AccessMode access_mode); |
| ~IsolateHolder(); |
| // Should be invoked once before creating IsolateHolder instances to |
| @@ -52,10 +59,14 @@ class GIN_EXPORT IsolateHolder { |
| // thread. |
| void RemoveRunMicrotasksObserver(); |
| + // This method returns if v8::Locker is needed to access isolate. |
| + AccessMode does_use_v8_locker() { return access_mode_; } |
|
rmcilroy
2015/04/23 17:01:27
Should be access_mode() if it is a getter. (otherw
Primiano Tucci (use gerrit)
2015/04/23 17:20:32
+1.
Also please make it a const (i.e. AccessMode a
|
| + |
| private: |
| v8::Isolate* isolate_; |
| scoped_ptr<PerIsolateData> isolate_data_; |
| scoped_ptr<RunMicrotasksObserver> task_observer_; |
| + AccessMode access_mode_; |
| DISALLOW_COPY_AND_ASSIGN(IsolateHolder); |
| }; |