Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1100733003: Update {virtual,override} to follow C++11 style in ppapi. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
bbudge
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@override_ppapi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in ppapi. [Sending this chunk by itself since it's slightly less rote than the others] The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/b05b81d7617e11ae4612afc15aab69b6f57293fe Cr-Commit-Position: refs/heads/master@{#326504}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M ppapi/proxy/ppapi_proxy_test.h View 6 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ncarter (slow)
bbudge: Please review -- I added some missing overrides here to non-dtor methods in this ...
5 years, 8 months ago (2015-04-23 03:55:08 UTC) #2
bbudge
lgtm
5 years, 8 months ago (2015-04-23 13:30:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100733003/1
5 years, 8 months ago (2015-04-23 13:53:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 14:01:01 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 14:02:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b05b81d7617e11ae4612afc15aab69b6f57293fe
Cr-Commit-Position: refs/heads/master@{#326504}

Powered by Google App Engine
This is Rietveld 408576698