Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1100723002: Add SourceInformationFactory. (Closed)

Created:
5 years, 8 months ago by Johnni Winther
Modified:
5 years, 8 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleanup. #

Total comments: 4

Patch Set 3 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -146 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 2 chunks +11 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 5 chunks +4 lines, -48 lines 0 comments Download
M pkg/compiler/lib/src/dart2jslib.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/io/source_information.dart View 1 2 6 chunks +212 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/js/js.dart View 3 chunks +9 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 5 chunks +7 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 2 12 chunks +25 lines, -50 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 4 chunks +14 lines, -6 lines 0 comments Download
M pkg/js_ast/lib/src/printer.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/source_mapping_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 8 months ago (2015-04-21 10:51:14 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/1100723002/diff/20001/pkg/compiler/lib/src/io/source_information.dart File pkg/compiler/lib/src/io/source_information.dart (right): https://codereview.chromium.org/1100723002/diff/20001/pkg/compiler/lib/src/io/source_information.dart#newcode319 pkg/compiler/lib/src/io/source_information.dart:319: : super(sourceFile); indent++ https://codereview.chromium.org/1100723002/diff/20001/pkg/compiler/lib/src/ssa/builder.dart File pkg/compiler/lib/src/ssa/builder.dart (right): https://codereview.chromium.org/1100723002/diff/20001/pkg/compiler/lib/src/ssa/builder.dart#newcode1457 ...
5 years, 8 months ago (2015-04-21 11:31:53 UTC) #3
Johnni Winther
https://codereview.chromium.org/1100723002/diff/20001/pkg/compiler/lib/src/io/source_information.dart File pkg/compiler/lib/src/io/source_information.dart (right): https://codereview.chromium.org/1100723002/diff/20001/pkg/compiler/lib/src/io/source_information.dart#newcode319 pkg/compiler/lib/src/io/source_information.dart:319: : super(sourceFile); On 2015/04/21 11:31:53, floitsch wrote: > indent++ ...
5 years, 8 months ago (2015-04-21 12:07:01 UTC) #4
Johnni Winther
5 years, 8 months ago (2015-04-21 12:08:44 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 45312 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698