bindings: Do not use ScriptWrappable::wrap for RemoteDOMWindow.

bindings: Do not use ScriptWrappable::wrap for RemoteDOMWindow.

Custom toV8(EventTarget*) has been handling LocalDOMWindow in a special
manner so that custom toV8(DOMWindow*) is always used.  However, when
RemoteDOMWindow, and DOMWindow as their superclass, were introduced, we
didn't add the same support for RemoteDOMWindow nor DOMWindow.  It was
wrong.

When toV8(EventTarget*) is called with a RemoteDOMWindow before
installDOMWindow is called, toV8(EventTarget*) calls
RemoteDOMWindow::wrap() and it creates a wrapper.  After that, when
installDOMWindow is called, the wrapper already exists for the
RemoteDOMWindow and it causes crash.

I think this is the cause of mysterious crashes around installDOMWindow.

This CL fixes:
- Makes sure that DOMWindow::wrap is never called.
- Calls toV8(DOMWindow*) for not only LocalDOMWindow but also
  RemoteDOMWindow.

I've confirmed that crash occurs at www.nhl.com with --site-per-process
specified, and fix with this CL.

BUG=478890, 477410, 475880
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194193

[Yuki, 2015-04-21 09:20:41]

yukishiino@chromium.org changed reviewers:
+ dcheng@chromium.org, haraken@chromium.org

[Yuki, 2015-04-21 09:20:41]

Could you guys review this CL?

[haraken, 2015-04-21 10:14:59]

LGTM, great detective work!

[dcheng, 2015-04-21 13:40:33]

lgtm, thanks for tracking this down!

[Yuki, 2015-04-22 04:12:05]

The CQ bit was checked by yukishiino@chromium.org

[Yuki, 2015-04-22 04:12:05]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1100693002/#ps60001
(title: "Fixed ActivityLoggerTest.")

[commit-bot: I haz the power, 2015-04-22 04:12:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1100693002/60001

[commit-bot: I haz the power, 2015-04-22 04:16:38]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194193

[alancutter (OOO until 2018), 2015-04-22 08:29:18]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1100893002/ by alancutter@chromium.org.

The reason for reverting is: This causes the following test to fail:
out/Release/browser_tests --gtest_filter=ActivityLogApiTest.TriggerEvent
This is preventing Blink from rolling:
https://codereview.chromium.org/1102483002.

[Yuki, 2015-04-22 12:45:29]

Patchset #5 (id:80001) has been deleted