Issue 1100673002: Wrap harmony implementations in functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1100673002: Wrap harmony implementations in functions. (Closed)

Created:
5 years, 8 months ago by Yang

Modified:
5 years, 8 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Wrap harmony implementations in functions. R=jkummerow@chromium.org Committed: https://crrev.com/95f6b726c02823939340badf20ef0acdc6a63a12 Cr-Commit-Position: refs/heads/master@{#27955}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+87 lines, -90 lines)			Patch
M	src/ast-value-factory.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/bootstrapper.cc	View	1 chunk	+6 lines, -8 lines	0 comments	Download
M	src/harmony-array.js	View	2 chunks	+23 lines, -30 lines	0 comments	Download
M	src/harmony-array-includes.js	View	2 chunks	+11 lines, -13 lines	0 comments	Download
M	src/harmony-reflect.js	View	1 chunk	+9 lines, -9 lines	0 comments	Download
M	src/harmony-regexp.js	View	2 chunks	+9 lines, -9 lines	0 comments	Download
M	src/harmony-spread.js	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	src/harmony-tostring.js	View	1 chunk	+10 lines, -8 lines	0 comments	Download
M	src/harmony-typedarray.js	View	3 chunks	+5 lines, -9 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100673002/1

5 years, 8 months ago (2015-04-21 09:14:00 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-21 09:42:36 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/95f6b726c02823939340badf20ef0acdc6a63a12
Cr-Commit-Position: refs/heads/master@{#27955}