Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1100633004: Update {virtual,override} to follow C++11 style in cloud_print. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in cloud_print. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/80b796a8539bf302d4d4aa420356d0f8c0d46063 Cr-Commit-Position: refs/heads/master@{#327154}

Patch Set 1 #

Patch Set 2 : Fix compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -75 lines) Patch
M cloud_print/gcp20/prototype/cloud_print_request.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cloud_print/gcp20/prototype/cloud_print_requester.h View 1 chunk +12 lines, -12 lines 0 comments Download
M cloud_print/gcp20/prototype/cloud_print_url_request_context_getter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M cloud_print/gcp20/prototype/cloud_print_xmpp_listener.h View 2 chunks +5 lines, -5 lines 0 comments Download
M cloud_print/gcp20/prototype/printer.h View 2 chunks +36 lines, -37 lines 0 comments Download
M cloud_print/gcp20/prototype/privet_http_server.h View 1 1 chunk +5 lines, -6 lines 0 comments Download
M cloud_print/service/win/chrome_launcher.h View 1 chunk +3 lines, -2 lines 0 comments Download
M cloud_print/service/win/cloud_print_service_config.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cloud_print/service/win/service_listener.h View 1 chunk +3 lines, -3 lines 0 comments Download
M cloud_print/service/win/setup_listener.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ncarter (slow)
Hi vitalybuka@ -- please review! thanks.
5 years, 8 months ago (2015-04-23 14:09:17 UTC) #2
ncarter (slow)
vitaly: friendly ping
5 years, 8 months ago (2015-04-24 16:11:39 UTC) #3
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 8 months ago (2015-04-27 21:42:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100633004/20001
5 years, 8 months ago (2015-04-27 21:42:57 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-27 22:15:05 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 22:16:25 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/80b796a8539bf302d4d4aa420356d0f8c0d46063
Cr-Commit-Position: refs/heads/master@{#327154}

Powered by Google App Engine
This is Rietveld 408576698