Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1100623003: ChromeOS Gaia: Polishing Offline UI and Password changed UI according to specs (Closed)

Created:
5 years, 8 months ago by Roman Sorokin (ftl)
Modified:
5 years, 8 months ago
Reviewers:
Dmitry Polukhin
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS Gaia: Polishing Offline UI and Password changed UI according to specs https://folio.googleplex.com/login-m44/Redlines BUG=478449 TEST=manual Committed: https://crrev.com/fcf6c134d7a3db415bb0f748dddc96398c24c465 Cr-Commit-Position: refs/heads/master@{#326772}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -47 lines) Patch
M chrome/browser/resources/chromeos/login/gaia_card.css View 2 chunks +21 lines, -17 lines 0 comments Download
M chrome/browser/resources/chromeos/login/gaia_card.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/gaia_header.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/gaia_input_form.css View 1 chunk +17 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/gaia_password_changed.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/gaia_password_changed.html View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/login/offline_gaia.css View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/resources/chromeos/login/offline_gaia.html View 2 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/login/offline_gaia.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Roman Sorokin (ftl)
Nikita, please review
5 years, 8 months ago (2015-04-24 09:42:15 UTC) #2
Roman Sorokin (ftl)
Dmitry, please review
5 years, 8 months ago (2015-04-24 10:52:28 UTC) #4
Dmitry Polukhin
lgtm
5 years, 8 months ago (2015-04-24 11:09:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100623003/1
5 years, 8 months ago (2015-04-24 11:09:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 11:37:21 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 11:38:08 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fcf6c134d7a3db415bb0f748dddc96398c24c465
Cr-Commit-Position: refs/heads/master@{#326772}

Powered by Google App Engine
This is Rietveld 408576698