Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1100563002: Remove font-variant CSSValueList conversion code (Closed)

Created:
5 years, 8 months ago by rwlbuis
Modified:
5 years, 8 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove font-variant CSSValueList conversion code There does not seem to be any reason to convert the single CSSPrimitiveValue into a CSSValueList. This may have made sense when these types were still exposed to the bindings. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194074

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -16 lines) Patch
M Source/core/css/CSSProperty.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/css/parser/CSSParserImpl.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
rwlbuis
PTAL
5 years, 8 months ago (2015-04-20 21:52:48 UTC) #2
Timothy Loh
lgtm
5 years, 8 months ago (2015-04-21 01:10:59 UTC) #3
Timothy Loh
On 2015/04/21 01:10:59, Timothy Loh wrote: > lgtm Maybe could do with a better patch ...
5 years, 8 months ago (2015-04-21 01:11:19 UTC) #4
rwlbuis
On 2015/04/21 01:11:19, Timothy Loh wrote: > On 2015/04/21 01:10:59, Timothy Loh wrote: > > ...
5 years, 8 months ago (2015-04-21 01:50:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100563002/1
5 years, 8 months ago (2015-04-21 01:51:56 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 02:56:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194074

Powered by Google App Engine
This is Rietveld 408576698