Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 1100503003: Add operator== to WebScreenInfo. (Closed)

Created:
5 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 8 months ago
Reviewers:
Mike West
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add operator== to WebScreenInfo. It's needed by Chromium to check whether two generated WebScreenInfo are identical. BUG=475939 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194105

Patch Set 1 #

Patch Set 2 : add testS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -0 lines) Patch
A Source/platform/WebScreenInfoTest.cpp View 1 1 chunk +59 lines, -0 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebScreenInfo.h View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mlamouri (slow - plz ping)
5 years, 8 months ago (2015-04-20 21:44:38 UTC) #2
Mike West
lgtm LGTM
5 years, 8 months ago (2015-04-21 04:40:23 UTC) #4
Mike West
On 2015/04/21 at 04:40:23, Mike West wrote: > lgtm > > LGTM (Can you add ...
5 years, 8 months ago (2015-04-21 04:40:52 UTC) #6
mlamouri (slow - plz ping)
PTAL
5 years, 8 months ago (2015-04-21 09:32:48 UTC) #7
Mike West
LGTM if the bots are happy!
5 years, 8 months ago (2015-04-21 09:35:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100503003/20001
5 years, 8 months ago (2015-04-21 09:36:28 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 10:56:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194105

Powered by Google App Engine
This is Rietveld 408576698