Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1100483005: bluetooth: Refactor device/bluetooth for C++ Style: typedef ordering. (Closed)

Created:
5 years, 8 months ago by scheib
Modified:
5 years, 8 months ago
Reviewers:
armansito
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Refactor device/bluetooth for C++ Style: typedef ordering. Refactoring in preparation of additional code changes to BluetoothAdapter before implementing an Android version. No code line changes, only moved blocks of typedef to match style guide ordering: https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Declaration_Order BUG=471536 Committed: https://crrev.com/a0e1d944baa8b4280ca884f44c89a56f21399188 Cr-Commit-Position: refs/heads/master@{#326163}

Patch Set 1 #

Patch Set 2 : typedefs for all of src/device/bluetooth #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -31 lines) Patch
M device/bluetooth/bluetooth_adapter.h View 7 chunks +16 lines, -13 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_chromeos.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_device.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_device_win.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_gatt_descriptor.h View 1 2 chunks +8 lines, -8 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_chromeos.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_chromeos.h View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
scheib
5 years, 8 months ago (2015-04-20 22:24:22 UTC) #2
armansito
I prefer not having this kind of refactor patches if possible. Otherwise if you'll do ...
5 years, 8 months ago (2015-04-20 22:51:01 UTC) #3
scheib
On 2015/04/20 22:51:01, armansito wrote: > I prefer not having this kind of refactor patches ...
5 years, 8 months ago (2015-04-21 00:31:26 UTC) #4
armansito
lgtm
5 years, 8 months ago (2015-04-21 23:07:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100483005/20001
5 years, 8 months ago (2015-04-21 23:12:07 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-21 23:16:41 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 23:17:30 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a0e1d944baa8b4280ca884f44c89a56f21399188
Cr-Commit-Position: refs/heads/master@{#326163}

Powered by Google App Engine
This is Rietveld 408576698