Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1100413003: Remove validation exceptions in GrGLInterface. These are all now set by Chromium. (Closed)

Created:
5 years, 8 months ago by bsalomon
Modified:
5 years, 8 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove validation exceptions in GrGLInterface. These are all now set by Chromium. Committed: https://skia.googlesource.com/skia/+/42d9f35a8daf7f24ba542ba3783ec46fd965ef2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M src/gpu/gl/GrGLInterface.cpp View 4 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bsalomon
5 years, 8 months ago (2015-04-24 14:15:23 UTC) #2
joshualitt
On 2015/04/24 14:15:23, bsalomon wrote: lgtm
5 years, 8 months ago (2015-04-24 14:29:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100413003/1
5 years, 8 months ago (2015-04-24 14:33:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/42d9f35a8daf7f24ba542ba3783ec46fd965ef2f
5 years, 8 months ago (2015-04-24 14:38:49 UTC) #6
tomhudson
Brian, We started getting crashes on https://uberchromegw.corp.google.com/i/client.skia/builders/Linux%20Tests after this landed, just like last time there ...
5 years, 8 months ago (2015-04-24 17:57:45 UTC) #7
bsalomon
5 years, 8 months ago (2015-04-24 18:08:08 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1093323005/ by bsalomon@google.com.

The reason for reverting is: Crashing bots.

Powered by Google App Engine
This is Rietveld 408576698