Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issue 1100413002: Add minisp32.dll to Chrome's Browser's Blacklist (Closed)

Created:
5 years, 8 months ago by csharp
Modified:
5 years, 8 months ago
Reviewers:
rkaplow, Cait (Slow)
CC:
chromium-reviews, asvitkine+watch_chromium.org, caitkp+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add minisp32.dll to Chrome's Browser's Blacklist BUG=476648, 479710 Committed: https://crrev.com/d5a8afb92f046e2e0f8780634cc3b7a401506342 Cr-Commit-Position: refs/heads/master@{#326784}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome_elf/blacklist/blacklist.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
csharp
caitkp@ for reviewing blacklist.cc rkaplow@ for reviewing histograms.xml
5 years, 8 months ago (2015-04-23 20:44:20 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100413002/1
5 years, 8 months ago (2015-04-23 20:48:56 UTC) #4
Cait (Slow)
blacklist.cc LGTM
5 years, 8 months ago (2015-04-23 21:24:53 UTC) #5
rkaplow
lgtm should get asvitkine to review as well.
5 years, 8 months ago (2015-04-23 21:30:42 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-23 22:31:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100413002/1
5 years, 8 months ago (2015-04-24 13:44:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 13:45:15 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d5a8afb92f046e2e0f8780634cc3b7a401506342 Cr-Commit-Position: refs/heads/master@{#326784}
5 years, 8 months ago (2015-04-24 13:46:11 UTC) #12
chromium-reviews
+Pawel Pawel, how did this get committed by the cq without owners approval for tools/metrics ...
5 years, 8 months ago (2015-04-24 15:29:31 UTC) #13
chromium-reviews
5 years, 8 months ago (2015-04-24 16:48:39 UTC) #14
Message was sent while issue was closed.
+infra-dev - any idea why this change bypassed OWNERS checks?

On Fri, Apr 24, 2015 at 11:28 AM, Alexei Svitkine <asvitkine@google.com>
wrote:

> +Pawel
>
> Pawel, how did this get committed by the cq without owners approval for
> tools/metrics OWNERS?
>
> On Fri, Apr 24, 2015 at 9:46 AM, <commit-bot@chromium.org> wrote:
>
>> Patchset 1 (id:??) landed as
>> https://crrev.com/d5a8afb92f046e2e0f8780634cc3b7a401506342
>> Cr-Commit-Position: refs/heads/master@{#326784}
>>
>> https://codereview.chromium.org/1100413002/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698