Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1100403004: Add skipWaiting checkbox to ServiceWorkersView in DevTools [2/2 blink] (Closed)

Created:
5 years, 8 months ago by horo
Modified:
5 years, 8 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add skipWaiting checkbox to ServiceWorkersView in DevTools [2/2 blink] 1/2 chromium: https://codereview.chromium.org/1102263002/ 2/2 blink: this cl screen shot: https://code.google.com/p/chromium/issues/detail?id=466871#c61 BUG=466871 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194570

Patch Set 1 #

Total comments: 4

Patch Set 2 : Use annotated named function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -11 lines) Patch
M Source/devtools/front_end/resources/ServiceWorkersView.js View 1 6 chunks +68 lines, -5 lines 0 comments Download
M Source/devtools/front_end/resources/serviceWorkersView.css View 5 chunks +13 lines, -6 lines 0 comments Download
M Source/devtools/front_end/sdk/ServiceWorkerManager.js View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
pfeldman
lgtm https://codereview.chromium.org/1100403004/diff/1/Source/devtools/front_end/resources/ServiceWorkersView.js File Source/devtools/front_end/resources/ServiceWorkersView.js (right): https://codereview.chromium.org/1100403004/diff/1/Source/devtools/front_end/resources/ServiceWorkersView.js#newcode318 Source/devtools/front_end/resources/ServiceWorkersView.js:318: this._registration.versions.valuesArray().map((function(version) { This should be an annotated named ...
5 years, 8 months ago (2015-04-27 16:47:30 UTC) #2
horo
Thank you! https://codereview.chromium.org/1100403004/diff/1/Source/devtools/front_end/resources/ServiceWorkersView.js File Source/devtools/front_end/resources/ServiceWorkersView.js (right): https://codereview.chromium.org/1100403004/diff/1/Source/devtools/front_end/resources/ServiceWorkersView.js#newcode318 Source/devtools/front_end/resources/ServiceWorkersView.js:318: this._registration.versions.valuesArray().map((function(version) { On 2015/04/27 16:47:30, pfeldman wrote: ...
5 years, 8 months ago (2015-04-28 02:18:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100403004/20001
5 years, 8 months ago (2015-04-28 03:44:01 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-28 04:53:51 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194570

Powered by Google App Engine
This is Rietveld 408576698