base: Fix warnings found by clang chromium-style plugin on Windows.

base: Fix warnings found by clang chromium-style plugin on Windows.

http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/596/steps/compile/logs/stdio

..\..\base/win/shortcut.h(51,3) :  warning(clang): [chromium-style] Complex constructor has an inlined body.
ShortcutProperties() : icon_index(-1), dual_mode(false), options(0U) {}
                      ^
..\..\base/win/shortcut.h(32,1) :  warning(clang): [chromium-style] Complex class/struct needs an explicit out-of-line destructor.
struct ShortcutProperties {
    ^
2 warnings generated.

BUG=467287
R=thakis@chromium.org

Committed: https://crrev.com/1a3d591bc4a1cf332320c098e849701205b70523
Cr-Commit-Position: refs/heads/master@{#326995}

[Nico, 2015-04-27 01:55:16]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-04-27 01:55:17]

lgtm

[commit-bot: I haz the power, 2015-04-27 01:55:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1100403003/1

[commit-bot: I haz the power, 2015-04-27 02:40:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-27 02:40:37]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Nico, 2015-04-27 02:44:08]

On 2015/04/27 02:40:37, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

Looks like the struct needs a BASE_EXPORT too.

[tfarina, 2015-04-27 02:44:43]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-04-27 02:44:43]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1100403003/#ps20001
(title: "BASE_EXPORT")

[commit-bot: I haz the power, 2015-04-27 02:44:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1100403003/20001

[commit-bot: I haz the power, 2015-04-27 03:51:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-27 03:52:10]

Patchset 2 (id:??) landed as
https://crrev.com/1a3d591bc4a1cf332320c098e849701205b70523
Cr-Commit-Position: refs/heads/master@{#326995}