Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1100363002: Fix incorrect handling of UNKNOWN captive portal state by supervised user creation screen. (Closed)

Created:
5 years, 8 months ago by Denis Kuznetsov (DE-MUC)
Modified:
5 years, 8 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, pam+watch_chromium.org, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix incorrect handling of UNKNOWN captive portal state by supervised user creation screen. BUG=480505 R=nkostylev@chromium.org Committed: https://crrev.com/4c65946fe8bf994d2cb478508a4d848c56cdab79 Cr-Commit-Position: refs/heads/master@{#326671}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Denis Kuznetsov (DE-MUC)
5 years, 8 months ago (2015-04-23 17:05:55 UTC) #1
Nikita (slow)
lgtm
5 years, 8 months ago (2015-04-23 21:17:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100363002/1
5 years, 8 months ago (2015-04-23 21:18:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 22:16:20 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 22:18:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c65946fe8bf994d2cb478508a4d848c56cdab79
Cr-Commit-Position: refs/heads/master@{#326671}

Powered by Google App Engine
This is Rietveld 408576698