chrome/browser/renderer_host/pepper/pepper_flash_browser_host.cc - Issue 1100293004: [chrome/browser/renderer_host] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/pepper/pepper_flash_browser_host.cc

Issue 1100293004: [chrome/browser/renderer_host] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removing changes Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/pepper/pepper_broker_message_filter.cc ('k') | chrome/browser/renderer_host/pepper/pepper_isolated_file_system_message_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/pepper/pepper_flash_browser_host.cc

diff --git a/chrome/browser/renderer_host/pepper/pepper_flash_browser_host.cc b/chrome/browser/renderer_host/pepper/pepper_flash_browser_host.cc

index 76b3e91a2774a1ede080ce2d56aded79c7153997..76ca5b9292cd78c19b6cdfccabb2cfb6411efd7c 100644

--- a/chrome/browser/renderer_host/pepper/pepper_flash_browser_host.cc

+++ b/chrome/browser/renderer_host/pepper/pepper_flash_browser_host.cc

@@ -36,7 +36,7 @@ namespace {

// Get the CookieSettings on the UI thread for the given render process ID.

scoped_refptr<CookieSettings> GetCookieSettings(int render_process_id) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

RenderProcessHost* render_process_host =

RenderProcessHost::FromID(render_process_id);

if (render_process_host && render_process_host->GetBrowserContext()) {

@@ -136,7 +136,7 @@ void PepperFlashBrowserHost::GetLocalDataRestrictions(

const GURL& document_url,

const GURL& plugin_url,

scoped_refptr<CookieSettings> cookie_settings) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

// Lazily initialize |cookie_settings_|. The cookie settings are thread-safe

// ref-counted so as long as we hold a reference to them we can safely access