Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1100283003: Oilpan: Oilpan's GC should not be triggered without having allocated any object (Closed)

Created:
5 years, 8 months ago by haraken
Modified:
5 years, 8 months ago
Reviewers:
oilpan-reviews, sof
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Oilpan's GC should not be triggered without having allocated any object This is a fix for a regression caused by r194282. With the current threshold, Oilpan's GC can be triggered without having allocated any object on Oilpan's heap. That is wrong. This CL changes the threshold so that Oilpan's GC is not triggered until Oilpan has allocated a certain amount of objects. BUG=474470 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194320

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M Source/platform/heap/ThreadState.cpp View 3 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
haraken
PTAL
5 years, 8 months ago (2015-04-23 16:53:19 UTC) #2
sof
lgtm, thanks very much for addressing right away.
5 years, 8 months ago (2015-04-23 18:56:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100283003/1
5 years, 8 months ago (2015-04-23 18:56:33 UTC) #5
haraken
I think this CL is fine, but we need to address the Platform::current() issue separately.
5 years, 8 months ago (2015-04-23 19:10:21 UTC) #6
sof
On 2015/04/23 19:10:21, haraken wrote: > I think this CL is fine, but we need ...
5 years, 8 months ago (2015-04-23 19:35:48 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 20:11:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194320

Powered by Google App Engine
This is Rietveld 408576698