Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1100273002: input[type=number] UI should reject invalid characters. (Closed)

Created:
5 years, 8 months ago by tkent
Modified:
5 years, 8 months ago
Reviewers:
keishi
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

input[type=number] UI should reject invalid characters. A number field silently ignores characters which can't be included in a number. It still accept invalid strings consisted of valid characters like "+++". BUG=365196 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194269

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -15 lines) Patch
M LayoutTests/fast/forms/number/number-keyoperation.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/number/number-keyoperation-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/number/number-l10n-input.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/number/number-l10n-input-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/number/number-placeholder-with-unacceptable-value.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/number/number-placeholder-with-unacceptable-value-expected.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/forms/number/number-reject-invalid.html View 1 chunk +44 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/number/number-reject-invalid-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/number/number-validity-badinput.html View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/forms/number/number-validity-badinput-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/validationMessage.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/NumberInputType.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/forms/NumberInputType.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/platform/text/PlatformLocale.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/platform/text/PlatformLocale.cpp View 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
Keishi, please review.
5 years, 8 months ago (2015-04-23 05:51:00 UTC) #3
keishi
On 2015/04/23 05:51:00, tkent wrote: > Keishi, please review. LGTM. I have a couple of ...
5 years, 8 months ago (2015-04-23 06:36:03 UTC) #4
tkent
On 2015/04/23 06:36:03, keishi wrote: > I have a couple of concerns. > BeforeTextInsertedEvent is ...
5 years, 8 months ago (2015-04-23 06:47:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100273002/20001
5 years, 8 months ago (2015-04-23 07:17:35 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 07:21:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194269

Powered by Google App Engine
This is Rietveld 408576698