Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2032)

Unified Diff: Source/web/WebDevToolsFrontendImpl.cpp

Issue 1100223003: bindings: Add empty checks for toV8() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebDevToolsFrontendImpl.cpp
diff --git a/Source/web/WebDevToolsFrontendImpl.cpp b/Source/web/WebDevToolsFrontendImpl.cpp
index 8fc2573655d23514498738c2ebc1939676bac400..6a8a85d16597e40bf1bc354c84663e686d39e233 100644
--- a/Source/web/WebDevToolsFrontendImpl.cpp
+++ b/Source/web/WebDevToolsFrontendImpl.cpp
@@ -85,6 +85,7 @@ void WebDevToolsFrontendImpl::didClearWindowObject(WebLocalFrameImpl* frame)
m_devtoolsHost = DevToolsHost::create(this, m_webFrame->frame());
v8::Handle<v8::Object> global = scriptState->context()->Global();
v8::Handle<v8::Value> devtoolsHostObj = toV8(m_devtoolsHost.get(), global, scriptState->isolate());
+ ASSERT(!devtoolsHostObj.IsEmpty());
haraken 2015/04/28 04:24:59 Who guarantees this is not empty?
bashi 2015/04/28 05:41:53 This is DevTool related code so I just guessed tha
global->Set(v8AtomicString(isolate, "DevToolsHost"), devtoolsHostObj);
}

Powered by Google App Engine
This is Rietveld 408576698