Source/bindings/core/v8/WindowProxy.cpp - Issue 1100223003: bindings: Add empty checks for toV8()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/WindowProxy.cpp

Issue 1100223003: bindings: Add empty checks for toV8() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/WindowProxy.cpp

diff --git a/Source/bindings/core/v8/WindowProxy.cpp b/Source/bindings/core/v8/WindowProxy.cpp

index c88a6e57b0d6dcfacd6c45ddb8933eebbe9db69f..a77ad70e5aa98dc7a9c854e2db41d518c1746932 100644

--- a/Source/bindings/core/v8/WindowProxy.cpp

+++ b/Source/bindings/core/v8/WindowProxy.cpp

@@ -364,6 +364,8 @@ void WindowProxy::updateDocumentProperty()

v8::Local<v8::Context> context = m_scriptState->context();

LocalFrame* frame = toLocalFrame(m_frame);

v8::Local<v8::Value> documentWrapper = toV8(frame->document(), context->Global(), context->GetIsolate());

+ if (documentWrapper.IsEmpty())

+ return;

ASSERT(documentWrapper == m_document.newLocal(m_isolate) || m_document.isEmpty());

if (m_document.isEmpty())

updateDocumentWrapper(v8::Local<v8::Object>::Cast(documentWrapper));