Source/bindings/core/v8/ScriptPromiseProperty.h - Issue 1100223003: bindings: Add empty checks for toV8()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptPromiseProperty.h

Issue 1100223003: bindings: Add empty checks for toV8() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptController.cpp ('K') | « Source/bindings/core/v8/ScriptController.cpp ('k') | Source/bindings/core/v8/ScriptValueSerializer.cpp » ('j') | Source/bindings/core/v8/ScriptValueSerializer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/ScriptPromiseProperty.h

diff --git a/Source/bindings/core/v8/ScriptPromiseProperty.h b/Source/bindings/core/v8/ScriptPromiseProperty.h

index cec372b6141abcd2e42d45858d1615c4f32f5aec..55c1b9aef94eb9d9bde418d3ea2e025651bf44e0 100644

--- a/Source/bindings/core/v8/ScriptPromiseProperty.h

+++ b/Source/bindings/core/v8/ScriptPromiseProperty.h

@@ -120,6 +120,8 @@ template<typename HolderType, typename ResolvedType, typename RejectedType>

v8::Handle<v8::Object> ScriptPromiseProperty<HolderType, ResolvedType, RejectedType>::holder(v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)

{

v8::Handle<v8::Value> value = toV8(m_holder, creationContext, isolate);

+ if (value.IsEmpty())

+ return v8::Handle<v8::Object>();

return value.As<v8::Object>();

}