Source/bindings/core/v8/Iterable.h - Issue 1100223003: bindings: Add empty checks for toV8()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/Iterable.h

Issue 1100223003: bindings: Add empty checks for toV8() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/Iterable.h

diff --git a/Source/bindings/core/v8/Iterable.h b/Source/bindings/core/v8/Iterable.h

index 43125b418db3b641bbe4eb1adcf768055dea30a5..75adecc53b3241c160a32d5db1e589711e3a0bba 100644

--- a/Source/bindings/core/v8/Iterable.h

+++ b/Source/bindings/core/v8/Iterable.h

@@ -64,6 +64,11 @@ public:

args[0] = toV8(value, creationContext, isolate);

args[1] = toV8(key, creationContext, isolate);

+ if (args[0].IsEmpty() || args[1].IsEmpty()) {

+ if (tryCatch.HasCaught())

+ exceptionState.rethrowV8Exception(tryCatch.Exception());

+ return;

+ }

v8::Local<v8::Value> result;

if (!V8ScriptRunner::callFunction(v8Callback, scriptState->executionContext(), v8ThisArg, 3, args, isolate).ToLocal(&result)) {