Source/core/dom/DOMDataView.cpp - Issue 1100223003: bindings: Add empty checks for toV8()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/DOMDataView.cpp

Issue 1100223003: bindings: Add empty checks for toV8() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/DOMDataView.cpp

diff --git a/Source/core/dom/DOMDataView.cpp b/Source/core/dom/DOMDataView.cpp

index 1092e10a98a93fd47442e9d451466807e9f63f29..617554f25de71809d97fe09a86ec9ee6f49d05a4 100644

--- a/Source/core/dom/DOMDataView.cpp

+++ b/Source/core/dom/DOMDataView.cpp

@@ -29,6 +29,8 @@ v8::Local<v8::Object> DOMDataView::wrap(v8::Isolate* isolate, v8::Local<v8::Obje

const WrapperTypeInfo* wrapperTypeInfo = this->wrapperTypeInfo();

v8::Local<v8::Value> v8Buffer = toV8(buffer(), creationContext, isolate);

+ if (v8Buffer.IsEmpty())

+ return v8::Handle<v8::Object>();

ASSERT(v8Buffer->IsArrayBuffer());

v8::Local<v8::Object> wrapper = v8::DataView::New(v8Buffer.As<v8::ArrayBuffer>(), byteOffset(), byteLength());