Source/bindings/core/v8/V8EventListener.cpp - Issue 1100223003: bindings: Add empty checks for toV8()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8EventListener.cpp

Issue 1100223003: bindings: Add empty checks for toV8() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/V8EventListener.cpp

diff --git a/Source/bindings/core/v8/V8EventListener.cpp b/Source/bindings/core/v8/V8EventListener.cpp

index 0f885be918d0253085cd0259fc40c984b6e37eb4..67877baa728ee8f90100c82f3b7e25215bd4dd07 100644

--- a/Source/bindings/core/v8/V8EventListener.cpp

+++ b/Source/bindings/core/v8/V8EventListener.cpp

@@ -75,6 +75,7 @@ v8::Local<v8::Function> V8EventListener::getListenerFunction(ScriptState* script

v8::Local<v8::Value> V8EventListener::callListenerFunction(ScriptState* scriptState, v8::Local<v8::Value> jsEvent, Event* event)

{

+ ASSERT(!jsEvent.IsEmpty());

v8::Local<v8::Function> handlerFunction = getListenerFunction(scriptState);

v8::Local<v8::Object> receiver = getReceiverObject(scriptState, event);

if (handlerFunction.IsEmpty() || receiver.IsEmpty())