Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Side by Side Diff: Source/bindings/core/v8/V8ErrorHandler.cpp

Issue 1100223003: bindings: Add empty checks for toV8() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 42
43 namespace blink { 43 namespace blink {
44 44
45 V8ErrorHandler::V8ErrorHandler(v8::Local<v8::Object> listener, bool isInline, Sc riptState* scriptState) 45 V8ErrorHandler::V8ErrorHandler(v8::Local<v8::Object> listener, bool isInline, Sc riptState* scriptState)
46 : V8EventListener(listener, isInline, scriptState) 46 : V8EventListener(listener, isInline, scriptState)
47 { 47 {
48 } 48 }
49 49
50 v8::Local<v8::Value> V8ErrorHandler::callListenerFunction(ScriptState* scriptSta te, v8::Local<v8::Value> jsEvent, Event* event) 50 v8::Local<v8::Value> V8ErrorHandler::callListenerFunction(ScriptState* scriptSta te, v8::Local<v8::Value> jsEvent, Event* event)
51 { 51 {
52 ASSERT(!jsEvent.IsEmpty());
52 if (!event->hasInterface(EventNames::ErrorEvent)) 53 if (!event->hasInterface(EventNames::ErrorEvent))
53 return V8EventListener::callListenerFunction(scriptState, jsEvent, event ); 54 return V8EventListener::callListenerFunction(scriptState, jsEvent, event );
54 55
55 ErrorEvent* errorEvent = static_cast<ErrorEvent*>(event); 56 ErrorEvent* errorEvent = static_cast<ErrorEvent*>(event);
56 if (errorEvent->world() && errorEvent->world() != &world()) 57 if (errorEvent->world() && errorEvent->world() != &world())
57 return v8::Null(isolate()); 58 return v8::Null(isolate());
58 59
59 v8::Local<v8::Object> listener = getListenerObject(scriptState->executionCon text()); 60 v8::Local<v8::Object> listener = getListenerObject(scriptState->executionCon text());
60 if (listener.IsEmpty() || !listener->IsFunction()) 61 if (listener.IsEmpty() || !listener->IsFunction())
61 return v8::Null(isolate()); 62 return v8::Null(isolate());
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 V8HiddenValue::setHiddenValue(isolate, v8::Local<v8::Object>::Cast(wrapp edEvent), V8HiddenValue::error(isolate), data); 96 V8HiddenValue::setHiddenValue(isolate, v8::Local<v8::Object>::Cast(wrapp edEvent), V8HiddenValue::error(isolate), data);
96 } 97 }
97 } 98 }
98 99
99 bool V8ErrorHandler::shouldPreventDefault(v8::Local<v8::Value> returnValue) 100 bool V8ErrorHandler::shouldPreventDefault(v8::Local<v8::Value> returnValue)
100 { 101 {
101 return returnValue->IsBoolean() && returnValue.As<v8::Boolean>()->Value(); 102 return returnValue->IsBoolean() && returnValue.As<v8::Boolean>()->Value();
102 } 103 }
103 104
104 } // namespace blink 105 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698