Issue 1100183002: debug: cache SharedFunctionInfo for multi-bp set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1100183002: debug: cache SharedFunctionInfo for multi-bp set

Created:
5 years, 8 months ago by fedor.indutny

Modified:
5 years, 6 months ago

Reviewers:
yangguo

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

debug: cache SharedFunctionInfo for multi-bp set When setting multiple breakpoints at once for a single script - cache the SharedFunctionInfos from it to avoid repeatedly iterating through the heap. BUG=4052 R=yangguo

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+183 lines, -39 lines)			Patch
M	src/debug.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/debug.cc	View	6 chunks	+151 lines, -38 lines	0 comments	Download
M	src/debug-debugger.js	View	1 chunk	+11 lines, -1 line	0 comments	Download
M	src/runtime/runtime.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime/runtime-debug.cc	View	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

On 2015/04/22 18:39:28, fedor wrote: Haven't had time to review this yet. Will do tomorrow ...

5 years, 8 months ago (2015-04-23 13:54:21 UTC) #2

Yang

5 years, 6 months ago (2015-06-26 07:06:46 UTC) #4

On 2015/05/05 14:28:00, fedor wrote:
> Yang,
> 
> Any news? ;)

Doh. You sent this to my @google.com account where it got drowned out. It didn't
show up on my @chromium.org account which I use daily... Sorry about this. In
the meantime I found a better solution for issue 4052.

Expand Messages | Collapse Messages