Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2547)

Unified Diff: base/trace_event/winheap_dump_provider.h

Issue 1100173002: Add a WinHeap dump provider to the memory profiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/winheap_dump_provider.h
diff --git a/base/trace_event/winheap_dump_provider.h b/base/trace_event/winheap_dump_provider.h
new file mode 100644
index 0000000000000000000000000000000000000000..29e9323e40347625206749285ac71c0cdb3d063d
--- /dev/null
+++ b/base/trace_event/winheap_dump_provider.h
@@ -0,0 +1,56 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BASE_TRACE_EVENT_WINHEAP_DUMP_PROVIDER_H_
+#define BASE_TRACE_EVENT_WINHEAP_DUMP_PROVIDER_H_
+
+#include <istream>
Primiano Tucci (use gerrit) 2015/04/22 23:48:32 out of curiosity, what do you need istream for in
Sébastien Marchand 2015/04/23 10:52:03 It's a leftover from one of my experiments :), rem
+#include <set>
+
+#include "base/memory/singleton.h"
+#include "base/trace_event/memory_dump_provider.h"
+
+namespace base {
+namespace trace_event {
+
+// A structure containing some information about a given heap.
+struct WinHeapInfo {
+ HANDLE heap_id;
+ size_t committed_size;
+ size_t allocated_size;
+ size_t block_count;
+};
+
+// Dump provider which collects process-wide heap memory stats. This provider
+// iterates over all the heaps of the current process to gather some metrics
+// about them.
+class BASE_EXPORT WinHeapDumpProvider : public MemoryDumpProvider {
+ public:
+ static WinHeapDumpProvider* GetInstance();
+
+ // MemoryDumpProvider implementation.
+ bool DumpInto(ProcessMemoryDump* pmd) override;
+ const char* GetFriendlyName() const override;
+
+ protected:
+ // Retrieves the information about given heap. The |heap_info| should contain
Primiano Tucci (use gerrit) 2015/04/22 23:48:32 Should this friend the test class?
Sébastien Marchand 2015/04/23 10:52:03 Done.
+ // a valid handle to an existing heap. The blocks contained in the
+ // |block_to_skip| set will be ignored.
+ bool GetHeapInformation(WinHeapInfo* heap_info,
+ const std::set<void*>& block_to_skip);
+
+ // Exposed as protected for unittesting purposes.
+ WinHeapDumpProvider() { }
+ ~WinHeapDumpProvider() override { }
+
+ private:
+ friend struct DefaultSingletonTraits<WinHeapDumpProvider>;
+
+ DISALLOW_COPY_AND_ASSIGN(WinHeapDumpProvider);
+};
+
+} // namespace trace_event
+} // namespace base
+
+#endif // BASE_TRACE_EVENT_WINHEAP_DUMP_PROVIDER_H_

Powered by Google App Engine
This is Rietveld 408576698