Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 110013008: OS(MACOSX) and USE(WEBAUDIO_FFMPEG) are mutually exclusive (Closed)

Created:
6 years, 11 months ago by lgombos
Modified:
6 years, 11 months ago
CC:
blink-reviews, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

OS(MACOSX) and USE(WEBAUDIO_FFMPEG) are mutually exclusive. Simplify platform/audio to remove unnecessary tests. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164605

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -20 lines) Patch
M Source/platform/audio/FFTFrame.h View 4 chunks +5 lines, -17 lines 0 comments Download
M Source/platform/audio/ffmpeg/FFTFrameFFMPEG.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/mac/FFTFrameMac.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
lgombos
The change in the comment for FFTFrameFFMPEG.cpp is unrelated, but it is the correct change ...
6 years, 11 months ago (2014-01-05 06:17:18 UTC) #1
Raymond Toy (Google)
On 2014/01/05 06:17:18, lgombos wrote: > The change in the comment for FFTFrameFFMPEG.cpp is unrelated, ...
6 years, 11 months ago (2014-01-06 20:52:43 UTC) #2
Nico
"are mutually exclusive" in what sense?
6 years, 11 months ago (2014-01-06 21:24:00 UTC) #3
lgombos
On 2014/01/06 21:24:00, Nico wrote: > "are mutually exclusive" in what sense? In a sense ...
6 years, 11 months ago (2014-01-06 23:12:18 UTC) #4
Nico
lgtm i guess
6 years, 11 months ago (2014-01-07 00:53:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/110013008/1
6 years, 11 months ago (2014-01-07 19:37:16 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 19:44:39 UTC) #7
Message was sent while issue was closed.
Change committed as 164605

Powered by Google App Engine
This is Rietveld 408576698