Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 110013007: Fix the !defined(ENABLE_PLUGINS) code path (Closed)

Created:
6 years, 11 months ago by lgombos
Modified:
6 years, 11 months ago
Reviewers:
jam
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix the !defined(ENABLE_PLUGINS) code path to properly initialize return variables of the function when plugin support is disabled build time. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
lgombos
Fix the !defined(ENABLE_PLUGINS) code path.
6 years, 11 months ago (2014-01-03 21:56:38 UTC) #1
jam
lgtm
6 years, 11 months ago (2014-01-04 00:18:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/110013007/1
6 years, 11 months ago (2014-01-04 05:45:12 UTC) #3
commit-bot: I haz the power
Change committed as 243019
6 years, 11 months ago (2014-01-04 12:07:34 UTC) #4
qinmin
On 2014/01/04 12:07:34, I haz the power (commit-bot) wrote: > Change committed as 243019 This ...
6 years, 11 months ago (2014-01-06 21:24:12 UTC) #5
qinmin
On 2014/01/06 21:24:12, qinmin wrote: > On 2014/01/04 12:07:34, I haz the power (commit-bot) wrote: ...
6 years, 11 months ago (2014-01-06 21:26:49 UTC) #6
lgombos
> > This CL is causing crbug.com/331773, we intentionally leave the codepath for > > ...
6 years, 11 months ago (2014-01-06 22:04:21 UTC) #7
lgombos
6 years, 11 months ago (2014-01-06 22:05:38 UTC) #8
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/105273013/ by l.gombos@samsung.com.

The reason for reverting is: This CL is causing crbug.com/331773. We
intentionally leave the codepath for android in
https://chromiumcodereview.appspot.com/11742017..

Powered by Google App Engine
This is Rietveld 408576698