Issue 110013005: MIPS: Reland "Allocation site support for monomorphic StringAdds in BinaryOps".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 110013005: MIPS: Reland "Allocation site support for monomorphic StringAdds in BinaryOps". (Closed)

Created:
6 years, 11 months ago by kilvadyb

Modified:
6 years, 11 months ago

Reviewers:
Benedikt Meurer, Paul Lind, danno, kisg, palfia, dusmil

CC:
v8-dev

Base URL:
https://github.com/v8/v8.git@gbl

Visibility:
Public.

More Reviews

Description

MIPS: Reland "Allocation site support for monomorphic StringAdds in BinaryOps". Port r18444 (856f92e) BUG=

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -12 lines)			Patch
	M	src/mips/code-stubs-mips.cc	View		4 chunks	+53 lines, -12 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

LGTM, I will fix the nit when landing it. https://codereview.chromium.org/110013005/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): https://codereview.chromium.org/110013005/diff/1/src/mips/code-stubs-mips.cc#newcode4325 src/mips/code-stubs-mips.cc:4325: ...

6 years, 11 months ago (2014-01-02 21:36:14 UTC) #2

Committed as r18447.

Expand Messages | Collapse Messages