Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: src/isolate.cc

Issue 1100083002: Don't MISS if you read the hole from certain FastHoley arrays. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE and fix arm64 compilation. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.h ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 5427a8c319d59369dd8f6e5fbde3aea5789e1d43..b526a01535e23f03ac123b1fdf13de6ff3a79edf 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -2375,8 +2375,9 @@ bool Isolate::use_crankshaft() const {
bool Isolate::IsFastArrayConstructorPrototypeChainIntact() {
PropertyCell* no_elements_cell = heap()->array_protector();
- bool cell_reports_intact = no_elements_cell->value()->IsSmi() &&
- Smi::cast(no_elements_cell->value())->value() == 1;
+ bool cell_reports_intact =
+ no_elements_cell->value()->IsSmi() &&
+ Smi::cast(no_elements_cell->value())->value() == kArrayProtectorValid;
#ifdef DEBUG
Map* root_array_map =
@@ -2437,8 +2438,9 @@ void Isolate::UpdateArrayProtectorOnSetElement(Handle<JSObject> object) {
*object ||
current_context->get(Context::INITIAL_ARRAY_PROTOTYPE_INDEX) ==
*object) {
- PropertyCell::SetValueWithInvalidation(factory()->array_protector(),
- handle(Smi::FromInt(0), this));
+ PropertyCell::SetValueWithInvalidation(
+ factory()->array_protector(),
+ handle(Smi::FromInt(kArrayProtectorInvalid), this));
break;
}
context = current_context->get(Context::NEXT_CONTEXT_LINK);
« no previous file with comments | « src/isolate.h ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698