Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2673)

Unified Diff: src/hydrogen-instructions.h

Issue 1100083002: Don't MISS if you read the hole from certain FastHoley arrays. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE and fix arm64 compilation. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/hydrogen.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index 0434a1340767893c2f10630439bebb93a1502de2..ff25c58f354357468a8859239b26249180ab4a5e 100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -6461,7 +6461,8 @@ static const int kDefaultKeyedHeaderOffsetSentinel = -1;
enum LoadKeyedHoleMode {
NEVER_RETURN_HOLE,
- ALLOW_RETURN_HOLE
+ ALLOW_RETURN_HOLE,
+ CONVERT_HOLE_TO_UNDEFINED
};
@@ -6548,9 +6549,7 @@ class HLoadKeyed final : public HTemplateInstruction<3>,
}
private:
- HLoadKeyed(HValue* obj,
- HValue* key,
- HValue* dependency,
+ HLoadKeyed(HValue* obj, HValue* key, HValue* dependency,
ElementsKind elements_kind,
LoadKeyedHoleMode mode = NEVER_RETURN_HOLE,
int offset = kDefaultKeyedHeaderOffsetSentinel)
@@ -6620,8 +6619,8 @@ class HLoadKeyed final : public HTemplateInstruction<3>,
// Establish some checks around our packed fields
enum LoadKeyedBits {
kBitsForElementsKind = 5,
- kBitsForHoleMode = 1,
- kBitsForBaseOffset = 25,
+ kBitsForHoleMode = 2,
+ kBitsForBaseOffset = 24,
kBitsForIsDehoisted = 1,
kStartElementsKind = 0,
« no previous file with comments | « src/hydrogen.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698