Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: compiler/java/com/google/dart/compiler/parser/DartParser.java

Issue 11000054: Report error for non-const map literals used as statements (issue 5299) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/java/com/google/dart/compiler/parser/DartParser.java
===================================================================
--- compiler/java/com/google/dart/compiler/parser/DartParser.java (revision 13035)
+++ compiler/java/com/google/dart/compiler/parser/DartParser.java (working copy)
@@ -4222,7 +4222,14 @@
if (token == Token.STRING || token == Token.STRING_SEGMENT || token == Token.STRING_EMBED_EXP_START) {
int offset = skipStringLiteral(1);
if (peek(offset) == Token.COLON) {
- return parseExpressionStatement();
+ DartStatement statement = parseExpressionStatement();
+ if (statement instanceof DartExprStmt
+ && ((DartExprStmt) statement).getExpression() instanceof DartMapLiteral) {
+ reportError(
+ ((DartExprStmt) statement).getExpression(),
+ ParserErrorCode.NON_CONST_MAP_LITERAL_STATEMENT);
+ }
+ return statement;
}
}
return parseBlock();
« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698