Move validator_x86_XX.rl out of unreviewed.

src/trusted/validator_ragel/decoder_internal.h

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /*
  * This file contains common parts of x86-32 and x86-64 internals (inline
  * functions and defines).
  */
 
 #ifndef NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_RAGEL_DECODER_INTERNAL_H_
 #define NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_RAGEL_DECODER_INTERNAL_H_
 
-#include "native_client/src/trusted/validator_ragel/unreviewed/decoding.h"
+#include "native_client/src/trusted/validator_ragel/decoding.h"
 
 /*
  * Set of macroses used in actions defined in parse_instruction.rl to pull
  * parts of the instruction from a byte stream and store them for future use.
  */
 #define GET_REX_PREFIX() instruction.prefix.rex

[halyavin, 2013/03/13 14:01:06]

What is the difference between S, N, P and T?

[khim, 2013/03/19 14:54:46]

Just a first name of the argument. Replaced with X (and N where there are
numeric argument).

 #define GET_VEX_PREFIX2() vex_prefix2
 #define GET_VEX_PREFIX3() vex_prefix3
 #define SET_VEX_PREFIX3(P) vex_prefix3 = (P)
 #define SET_DATA16_PREFIX(S) instruction.prefix.data16 = (S)
 #define SET_LOCK_PREFIX(S) instruction.prefix.lock = (S)
 #define SET_REPZ_PREFIX(S) instruction.prefix.repz = (S)
 #define SET_REPNZ_PREFIX(S) instruction.prefix.repnz = (S)
 #define SET_BRANCH_TAKEN(S) instruction.prefix.branch_taken = (S)
 #define SET_BRANCH_NOT_TAKEN(S) instruction.prefix.branch_not_taken = (S)
 #define SET_INSTRUCTION_NAME(N) instruction.name = (N)
@@ skipping 52 matching lines @@
     case IMM8:    return AnyFieldValue8bit(imm_ptr);
     case IMM16:   return AnyFieldValue16bit(imm_ptr);
     case IMM32:   return AnyFieldValue32bit(imm_ptr);
     case IMM64:   return AnyFieldValue64bit(imm_ptr);
   }
   assert(FALSE);
   return 0;
 }
 
 #endif  /* NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_RAGEL_DECODER_INTERNAL_H_ */