Certificate Transparency: Fetching of Signed Tree Heads (DRAFT)

components/certificate_transparency.gypi

Index: components/certificate_transparency.gypi
diff --git a/components/devtools_discovery.gypi b/components/certificate_transparency.gypi
similarity index 51%
copy from components/devtools_discovery.gypi
copy to components/certificate_transparency.gypi
index 9b8232ceefba50ec75084a793312df5e7d50aabc..1a0f3655c3213a71d44350ffb54139b6c6ee1f3d 100644
--- a/components/devtools_discovery.gypi
+++ b/components/certificate_transparency.gypi
@@ -5,23 +5,23 @@
 {
   'targets': [
     {
-      'target_name': 'devtools_discovery',
+      # GN version: //components/certificate_transparency
+      'target_name': 'certificate_transparency',
       'type': 'static_library',

[davidben, 2015/05/07 21:59:36]

IMPORTANT: Because this is a static_library rather than <(component), while you
don't need a certificate_transparency_export.h, you cannot depend on this from
more than one component (in the shared library vs static library sense of the
word). Otherwise you get two copies of it. That's probably fine since //content
isn't going to depend on this anyway. But, for instance, content ->
certificate_transparency + chrome -> certificate_transparency isn't going to
work.

I don't have a good sense of which //components normally goes with. It seems to
mostly be static_library, but there are a few <(component)s. I guess that makes
sense since //content doesn't typically depend on these.

[Eran Messeri, 2015/06/18 15:18:43]

AFAICT the dependency now is chrome -> certificate_transparency -> content. Is
that sensible? I see no reason content will ever depend on that directly.

+      'include_dirs': [
+        '..',
+      ],
       'dependencies': [
         '../base/base.gyp:base',
-        '../content/content.gyp:content_browser',
         '../content/content.gyp:content_common',

[davidben, 2015/05/07 21:59:36]

This doesn't actually depend on //content (and the dependency isn't in GN or
DEPS).

[Eran Messeri, 2015/06/18 15:18:43]

It now does.

-      ],
-      'include_dirs': [
-        '..',
+        '../net/net.gyp:net',
       ],
       'sources': [
-        'devtools_discovery/basic_target_descriptor.cc',
-        'devtools_discovery/basic_target_descriptor.h',
-        'devtools_discovery/devtools_discovery_manager.cc',
-        'devtools_discovery/devtools_discovery_manager.h',
-        'devtools_discovery/devtools_target_descriptor.h',
+        'certificate_transparency/new_scts_observer.h',
+        'certificate_transparency/new_scts_observer.cc',
+        'certificate_transparency/log_proofs_fetcher.h',
+        'certificate_transparency/log_proofs_fetcher.cc',
       ],
-    },
+    }
   ],
 }