Certificate Transparency: Fetching of Signed Tree Heads (DRAFT)

components/certificate_transparency/new_scts_observer.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_CERTIFICATE_TRANSPARENCY_NEW_SCTS_OBSERVER_H_
+#define COMPONENTS_CERTIFICATE_TRANSPARENCY_NEW_SCTS_OBSERVER_H_
+
+#include <map>
+#include <string>
+
+#include "base/memory/linked_ptr.h"
+#include "base/memory/scoped_ptr.h"
+#include "net/cert/ct_verifier.h"
+
+namespace net {
+class CTLogVerifier;
+
+namespace ct {
+struct SignedCertificateTimestamp;
+struct SignedTreeHead;
+}  // namespace ct
+
+}  // namespace net
+
+namespace certificate_transparency {
+class LogProofsFetcher;

[Ryan Sleevi, 2015/04/24 10:42:08]

newline between 25 & 26

[Eran Messeri, 2015/06/18 15:18:42]

Done.

+
+class NewSCTsObserver : public net::CTVerifier::Observer {

[Ryan Sleevi, 2015/04/24 10:42:07]

Document

[Eran Messeri, 2015/06/18 15:18:42]

Done.

+ public:
+  NewSCTsObserver(LogProofsFetcher* fetcher);

[Ryan Sleevi, 2015/04/24 10:42:07]

since you take ownership of this (line 40), you should have this as

explicit NewSCTsObserver(scoped_ptr<LogProofsFetcher> fetcher);


(and use the .Pass() semantics which are equivalent to C++11 move semantics)

[Ryan Sleevi, 2015/04/24 10:42:07]

explicit

[Eran Messeri, 2015/06/18 15:18:42]

Ack, n/a anymore (c'tor has two parameters).

[Eran Messeri, 2015/06/18 15:18:42]

Done.

+  ~NewSCTsObserver() override;
+
+  void OnSCTVerified(const net::ct::SignedCertificateTimestamp* sct,
+                     net::CTLogVerifier* verifier) override;
+
+ private:
+  typedef std::map<std::string, linked_ptr<net::ct::SignedTreeHead>> IDToSTHMap;

[Ryan Sleevi, 2015/04/24 10:42:07]

This typedef isn't needed, is it? especially with the ability to use auto in the
C++ code

[Eran Messeri, 2015/06/18 15:18:42]

Done.

+
+  IDToSTHMap sths_;

[Ryan Sleevi, 2015/04/24 10:42:07]

document

[Eran Messeri, 2015/06/18 15:18:42]

Done.

+  scoped_ptr<LogProofsFetcher> fetcher_;
+
+  DISALLOW_COPY_AND_ASSIGN(NewSCTsObserver);
+};
+
+}  // namespace

[Ryan Sleevi, 2015/04/24 10:42:07]

// namespace certificate_transparency

[Eran Messeri, 2015/06/18 15:18:42]

Done.

+
+#endif

[Ryan Sleevi, 2015/04/24 10:42:07]

#endif  // COMPONENTS_CERTIFICATE_TRANSPARENCY_NEW_SCTS_OBSERVER_H_

[Eran Messeri, 2015/06/18 15:18:42]

Done.