Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: runtime/bin/common.cc

Issue 11000025: Revert hiding of VM-only coreimpl list implementation types. While I (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/builtin_natives.cc ('k') | runtime/bin/common.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/common.cc
diff --git a/runtime/bin/common.cc b/runtime/bin/common.cc
deleted file mode 100644
index 84d4dbabc82937591909321890d795dd6415342d..0000000000000000000000000000000000000000
--- a/runtime/bin/common.cc
+++ /dev/null
@@ -1,28 +0,0 @@
-// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-#include "bin/builtin.h"
-
-#include "include/dart_api.h"
-
-void FUNCTION_NAME(Common_IsBuiltinList)(Dart_NativeArguments args) {
- Dart_EnterScope();
- Dart_Handle list = Dart_GetNativeArgument(args, 0);
- Dart_Handle list_class = Dart_InstanceGetClass(list);
- ASSERT(!Dart_IsError(list_class));
- Dart_Handle coreimpl_lib =
- Dart_LookupLibrary(Dart_NewString("dart:coreimpl"));
- ASSERT(!Dart_IsError(coreimpl_lib));
- Dart_Handle object_array_class =
- Dart_GetClass(coreimpl_lib, Dart_NewString("_ObjectArray"));
- ASSERT(!Dart_IsError(object_array_class));
- Dart_Handle immutable_array_class =
- Dart_GetClass(coreimpl_lib, Dart_NewString("_ImmutableArray"));
- ASSERT(!Dart_IsError(immutable_array_class));
- // TODO(5474): We should be able to allow _GrowableObjectArrays here as well.
- bool builtin_array = (Dart_IdentityEquals(list_class, object_array_class) ||
- Dart_IdentityEquals(list_class, immutable_array_class));
- Dart_SetReturnValue(args, Dart_NewBoolean(builtin_array));
- Dart_ExitScope();
-}
« no previous file with comments | « runtime/bin/builtin_natives.cc ('k') | runtime/bin/common.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698