Revert hiding of VM-only coreimpl list implementation types. While I

runtime/vm/intrinsifier_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // The intrinsic code below is executed before a method has built its frame.
 // The return address is on the stack and the arguments below it.
 // Registers EDX (arguments descriptor) and ECX (function) must be preserved.
 // Each intrinsification method returns true if the corresponding
 // Dart method was intrinsified.
 
@@ skipping 156 matching lines @@
   return false;
 }
 
 
 bool Intrinsifier::ImmutableArray_getIndexed(Assembler* assembler) {
   return Array_getIndexed(assembler);
 }
 
 
 static intptr_t ComputeObjectArrayTypeArgumentsOffset() {
-  const String& class_name = String::Handle(Symbols::New("_ObjectArray"));
-  const Library& coreimpl_lib = Library::Handle(Library::CoreImplLibrary());
-  const Class& cls =
-      Class::Handle(coreimpl_lib.LookupClassAllowPrivate(class_name));
+  const String& class_name = String::Handle(Symbols::New("ObjectArray"));
+  const Class& cls = Class::Handle(
+      Library::Handle(Library::CoreImplLibrary()).LookupClass(class_name));
   ASSERT(!cls.IsNull());
   ASSERT(cls.HasTypeArguments());
   ASSERT(cls.NumTypeArguments() == 1);
   const intptr_t field_offset = cls.type_arguments_instance_field_offset();
   ASSERT(field_offset != Class::kNoTypeArguments);
   return field_offset;
 }
 
 
 // Intrinsify only for Smi value and index. Non-smi values need a store buffer
@@ skipping 54 matching lines @@
   __ ret();
   __ Bind(&fall_through);
   return false;
 }
 
 
 static intptr_t GetOffsetForField(const char* class_name_p,
                                   const char* field_name_p) {
   const String& class_name = String::Handle(Symbols::New(class_name_p));
   const String& field_name = String::Handle(Symbols::New(field_name_p));
-  const Library& coreimpl_lib = Library::Handle(Library::CoreImplLibrary());
-  const Class& cls =
-      Class::Handle(coreimpl_lib.LookupClassAllowPrivate(class_name));
+  const Class& cls = Class::Handle(Library::Handle(
+      Library::CoreImplLibrary()).LookupClass(class_name));
   ASSERT(!cls.IsNull());
   const Field& field = Field::ZoneHandle(cls.LookupInstanceField(field_name));
   ASSERT(!field.IsNull());
   return field.Offset();
 }
 
 
 // Allocate a GrowableObjectArray using the backing array specified.
 // On stack: type argument (+2), data (+1), return-address (+0).
 bool Intrinsifier::GArray_Allocate(Assembler* assembler) {
@@ skipping 1017 matching lines @@
   __ j(EQUAL, &is_true, Assembler::kNearJump);
   __ LoadObject(EAX, bool_false);
   __ ret();
   __ Bind(&is_true);
   __ LoadObject(EAX, bool_true);
   __ ret();
   return true;
 }
 
 
-static const char* kFixedSizeArrayIteratorClassName = "_FixedSizeArrayIterator";
+static const char* kFixedSizeArrayIteratorClassName = "FixedSizeArrayIterator";
 
 
 // Class 'FixedSizeArrayIterator':
 //   T next() {
 //     return _array[_pos++];
 //   }
 // Intrinsify: return _array[_pos++];
 // TODO(srdjan): Throw a 'NoMoreElementsException' exception if the iterator
 // has no more elements.
 bool Intrinsifier::FixedSizeArrayIterator_next(Assembler* assembler) {
@@ skipping 124 matching lines @@
   __ Bind(&is_true);
   __ LoadObject(EAX, bool_true);
   __ ret();
   return true;
 }
 
 #undef __
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32