Issue 11000010: We don't need to do both OleInitialize() and CoInitializeEx() on the same thread. Eliminate the Sc…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11000010: We don't need to do both OleInitialize() and CoInitializeEx() on the same thread. Eliminate the Sc… (Closed)

Created:
8 years, 2 months ago by Peter Kasting

Modified:
8 years, 2 months ago

Reviewers:
cpu_(ooo_6.6-7.5), jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

We don't need to do both OleInitialize() and CoInitializeEx() on the same thread. Eliminate the ScopedCOMInitializer that does the latter for the main thread, and move the ScopedOleInitializer that does the former into the same spot. BUG=none TEST=Running Win debug Chrome does not produce console output about duplicate COM initializations Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=159527

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -12 lines)			Patch
	M	content/browser/browser_main_loop.h	View		2 chunks	+0 lines, -8 lines	0 comments	Download
	M	content/browser/browser_main_runner.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages