Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1099993002: Actually disable Wallet card saving on Linux. (Closed)

Created:
5 years, 8 months ago by Evan Stade
Modified:
5 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Actually disable Wallet card saving on Linux. This isn't the ideal solution because I'd like to be able to pass a gyp-time flag to re-enable it (for testing purposes), but it's the smallest patch for merging. BUG=468045 Committed: https://crrev.com/423d45cbeb758ac43ad1456ae76987ba67a196e8 Cr-Commit-Position: refs/heads/master@{#326296}

Patch Set 1 #

Patch Set 2 : don't crash and burn #

Patch Set 3 : fix pdm tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill.gypi View 1 chunk +2 lines, -4 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 1 chunk +2 lines, -4 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 2 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Evan Stade
5 years, 8 months ago (2015-04-21 23:30:46 UTC) #2
brettw
lgtm
5 years, 8 months ago (2015-04-21 23:43:55 UTC) #3
Evan Stade
On 2015/04/21 23:43:55, brettw wrote: > lgtm had to make one more change to not ...
5 years, 8 months ago (2015-04-21 23:54:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099993002/20001
5 years, 8 months ago (2015-04-22 00:03:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/56505)
5 years, 8 months ago (2015-04-22 01:47:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099993002/40001
5 years, 8 months ago (2015-04-22 13:24:27 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-22 14:41:53 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 14:42:54 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/423d45cbeb758ac43ad1456ae76987ba67a196e8
Cr-Commit-Position: refs/heads/master@{#326296}

Powered by Google App Engine
This is Rietveld 408576698